D21282: CSI 2J: Do not append current screen to history

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

D21282: CSI 2J: Do not append current screen to history

David Barchiesi
View Revision
mglb created this revision.
mglb added a reviewer: Konsole.
mglb added a project: Konsole.
Herald added a subscriber: konsole-devel.
mglb requested review of this revision.

REVISION SUMMARY

This behavior is present in e.g. xterm and linux console.

Currently when using CSI 2J escape sequence, screen contents are
appended to scrollback (including bottom empty lines). This is breaking
clear command, which replaces scrollback with current screen contents.

BUG: 384218


TEST PLAN
  • Start Konsole with a shell
  • clear

Expected result:
Cleared display, empty scrollback.
Actual result:
Cleared display, but scrollback contains previous display contents.


  • Start Konsole with a shell
  • seq 1000
  • echo -ne '\033[2J

Expected result:
Cleared display, numbers in last scrollback lines.
Actual result:
Cleared display, but scrollback contains previous display contents
(i.e. shell prompt in last lines)


REPOSITORY
R319 Konsole

BRANCH
fix-clear (branched from master)


AFFECTED FILES
src/Screen.cpp

To: mglb, Konsole
Cc: konsole-devel, Konsole, gennad, thsurrel, ngraham, maximilianocuria, hindenburg