D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

D22727: allow kio-extras to build with mingw on win32 and remove unnecessary includes

Nathaniel Graham
View Revision
sredman added a comment.

The truth is stronger than "I would not recommend".
put() in SlaveBase-derived classes is called by the KIO library (TransferJob), so you CANNOT change the meaning of the arguments. It's part of the API/ABI for all slaves, and this cannot change until KF6.

+1

But it is worth making a note of this as something to change (or discuss changing) for KF6 since it seems like using the Qt constants would be a better design


REPOSITORY
R320 KIO Extras


To: brute4s99, vonreth, dfaure, pino
Cc: sredman, pino, kde-frameworks-devel, kfm-devel, aprcela, vmarinescu, fprice, LeGast00n, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, michaelh, spoorun, navarromorales, firef, ngraham, andrebarros, bruns, emmanuelp, mikesomov