D23232: [dolphin] Add an action to toggle the searchbar

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view

D23232: [dolphin] Add an action to toggle the searchbar

Nathaniel Graham
View Revision
ngraham added a comment.

I also think that using toggle for search makes more sense. It would be nice to have a general pattern of using toggle buttons in the toolbar for things that can be opened and closed, especially when they're activated via the toolbar in the first place.

+1. In fact, we already do have this pattern; there are just a few that don't conform.

R318 Dolphin

To: iasensio, Dolphin, ngraham, VDG
Cc: ndavis, felixernst, elvisangelaccio, kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov