D23295: [Tab Bar] Resolve tab icon lazily

classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

D23295: [Tab Bar] Resolve tab icon lazily

Nathaniel Graham
View Revision
broulik created this revision.
broulik added a reviewer: Dolphin.
Herald added a project: Dolphin.
Herald added a subscriber: kfm-devel.
broulik requested review of this revision.

REVISION SUMMARY

Calling KIO::iconNameForUrl will determine mime type of the file potentially blocking.
Don't needless do it when the tab bar isn't visible.


TEST PLAN

Browsed around, all was fine, opened a new tab, the icons were there just fine and updated properly


REPOSITORY
R318 Dolphin


AFFECTED FILES
src/dolphintabwidget.cpp
src/dolphintabwidget.h

To: broulik, Dolphin
Cc: kfm-devel, aprcela, vmarinescu, fprice, MrPepe, fbampaloukas, alexde, Codezela, feverfew, meven, spoorun, navarromorales, firef, andrebarros, emmanuelp, mikesomov