D8835: core, documented ScoreItem.qml

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
View Revision
asagtani created this revision.
asagtani added a reviewer: GCompris.
Restricted Application added a subscriber: KDE Edu.
Restricted Application added a project: KDE Edu.

REPOSITORY
R2 GCompris


AFFECTED FILES
src/core/ScoreItem.qml

To: asagtani, GCompris
Cc: asagtani, KDE Edu, narvaez, apol
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
View Revision
asagtani added a project: GCompris.

REPOSITORY
R2 GCompris


To: asagtani, GCompris
Cc: asagtani, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, jjazeix, bcoudoin
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
In reply to this post by Renato Oliveira Filho
View Revision
asagtani updated this revision to Diff 22821.

REPOSITORY
R2 GCompris



AFFECTED FILES
src/core/ScoreItem.qml

To: asagtani, GCompris
Cc: jjazeix, asagtani, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
In reply to this post by Renato Oliveira Filho
View Revision
jjazeix added inline comments.

INLINE COMMENTS
View InlineScoreItem.qml:29
*
* ScoreItem usually consists of player score (@ref playerScore)
* and player image (@ref playerImageSource).

no need of "usually", it is always the case


View InlineScoreItem.qml:101
/**
* Emitted when the other player turn should be started.
*

it's when the player turn ends not necessary when the other player needs to start


REPOSITORY
R2 GCompris


To: asagtani, GCompris
Cc: jjazeix, asagtani, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
In reply to this post by Renato Oliveira Filho
View Revision
jjazeix accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R2 GCompris


To: asagtani, GCompris, jjazeix
Cc: jjazeix, asagtani, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin
Reply | Threaded
Open this post in threaded view
|

D8835: core, documented ScoreItem.qml

Renato Oliveira Filho
In reply to this post by Renato Oliveira Filho
View Revision
jjazeix closed this revision.
jjazeix added a comment.

commited in https://cgit.kde.org/gcompris.git/commit/?id=1420e35ee356c01d95ccb6220c91d799f1c098c9

You full diff does not contain all the change (just the latest, I merged them manually).

I made a mistake with the author commit (I put myself instead of your name).

Thank you for the change.


REPOSITORY
R2 GCompris


To: asagtani, GCompris, jjazeix
Cc: jjazeix, asagtani, KDE Edu, nityanandkumar, echarruau, rahulyadav, narvaez, scagarwal, apol, timotheegiet, hkaelberer, bcoudoin