[Differential] [Request, 0 lines] D1092: Switch to Qt Resource-based icons for Kexi with breeze as cross-platform default

classic Classic list List threaded Threaded
10 messages Options
Reply | Threaded
Open this post in threaded view
|

[Differential] [Request, 0 lines] D1092: Switch to Qt Resource-based icons for Kexi with breeze as cross-platform default

Roman Gilg-2
staniek created this revision.
staniek added reviewers: piggz, kossebau, wkosowicz, wicik, kpawlowski.
staniek added a subscriber: Kexi-Devel-list.
staniek set the repository for this revision to rKEXI Kexi.
staniek added a project: Kexi.

REVISION SUMMARY
  This is for preview.
 
  - The patch is tool large because of file movements and deletions, see this commit (it applies to kexi.git master): http://commits.kde.org/scratch/staniek/kexi3/e5c6e7adb4710777db063ff4481f37b9cbd180bd
  - Please follow this thread for technical details: https://mail.kde.org/pipermail/kde-frameworks-devel/2016-March/032042.html
 
  Details:
 
  - works on Linux & Windows
  - old oxygen icons removed, breeze is the only fully officially supported theme; extra themes (as .rcc files) may be developed  in separate repositories
  - no support for themes from individual files: this can be developed and supplied as non-default option but for now no other icon theme is complete for Kexi
  - two levels of icon resources: Kexi's own kexi_breeze.rcc and generic breeze icons breeze.rcc
  - breeze.rcc should be generated from breeze-icons.git
  - Icons from kexi_breeze.rcc have priority over breeze.rcc
  - updated icons names based on the list from https://community.kde.org/Calligra/Icons/3.0
  - Kexi icon names are enclosed with KexiIcon macro (and similar ones), generic breeze icons are enclosed with kiIcon macro (and similar ones); this is useful to track missing icons using scripts from devtools/iconcheck/
  - by the way, move special pixmaps such as tableview_pen to resources

TEST PLAN
  To make it work, uncompress the breeze icons resource and kexi icons resource (http://kexi-project.org/tmp/breeze.rcc.bz2, http://kexi-project.org/tmp/kexi_breeze.rcc.bz2)  to PREFIX/share/kexi/icons/. Both files have dirs such as "icons/actions/32" etc. just like any XDG-compatible theme should have.
 
  Kexi with properly working icons (both the generic Breeze icons such as edit-paste.svg, and Kexi's own icons such as form.svg):
 
  F94056: import_table_object1.png <https://phabricator.kde.org/F94056>

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

AFFECTED FILES


EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski
Cc: Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
staniek retitled this revision from "Switch to Qt Resource-based icons for Kexi with breeze as cross-platform default" to "Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default".
staniek updated the summary for this revision.

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski
Cc: Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
staniek updated the summary for this revision.
staniek added a reviewer: kfunk.
staniek added a subscriber: kfunk.

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski, kfunk
Cc: kfunk, Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
staniek updated the summary for this revision.

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski, kfunk
Cc: kfunk, Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
staniek updated the summary for this revision.

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski, kfunk
Cc: habacker, kfunk, Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
kfunk removed a reviewer: kfunk.

REPOSITORY
  rKEXI Kexi

REVISION DETAIL
  https://phabricator.kde.org/D1092

EMAIL PREFERENCES
  https://phabricator.kde.org/settings/panel/emailpreferences/

To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski
Cc: habacker, Kexi-Devel-list, staniek
_______________________________________________
Kexi-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kexi-devel
Reply | Threaded
Open this post in threaded view
|

[Differential] [Updated] D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
View Revision
staniek added a comment.

@piggz could you please approve? it was pushed in March already (7af96966d08fb3063a) and improved many times since


REPOSITORY
rKEXI Kexi



To: staniek, piggz, kossebau, wkosowicz, wicik, kpawlowski
Cc: habacker, Kexi-Devel-list, staniek
Reply | Threaded
Open this post in threaded view
|

D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
View Revision
kossebau resigned from this revision.

REPOSITORY
R71 Kexi


To: staniek, piggz, wkosowicz, wicik, kossebau, kpawlowski
Cc: habacker, Kexi-Devel-list, staniek
Reply | Threaded
Open this post in threaded view
|

D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
View Revision
piggz accepted this revision.
This revision is now accepted and ready to land.

REPOSITORY
R71 Kexi


To: staniek, piggz, wkosowicz, wicik, kpawlowski
Cc: habacker, Kexi-Devel-list, barman, staniek
Reply | Threaded
Open this post in threaded view
|

D1092: Switch to Qt Resource-based icon theme for Kexi with breeze as cross-platform default

Roman Gilg-2
In reply to this post by Roman Gilg-2
View Revision
staniek closed this revision.
staniek added a comment.

Landed long ago.


REPOSITORY
R71 Kexi


To: staniek, piggz, wkosowicz, wicik, kpawlowski
Cc: habacker, Kexi-Devel-list, barman, staniek