Differential Review

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Differential Review

John Salatas-2
Hi.

Seems that lately kompare isn't so active. Is anyone watching this list?

I created a Differential Review (https://phabricator.kde.org/D5075),
fixing some issues, but wasn't sure who should I add to review it, so I
just added the last two committers according to git's logs. :)

Can someone have a look?

Thanks!

Reply | Threaded
Open this post in threaded view
|

Re: Differential Review

Jeremy Whiting
Hi John,

Those changes look good to me, but as Kevin said please split it into two commits since it fixes two issues.

thanks,
Jeremy

On Sat, Mar 18, 2017 at 12:50 AM, John Salatas <[hidden email]> wrote:
Hi.

Seems that lately kompare isn't so active. Is anyone watching this list?

I created a Differential Review (https://phabricator.kde.org/D5075), fixing some issues, but wasn't sure who should I add to review it, so I just added the last two committers according to git's logs. :)

Can someone have a look?

Thanks!


Reply | Threaded
Open this post in threaded view
|

Re: Differential Review

John Salatas-2
Already split and committed, according to Kevin's review:

https://phabricator.kde.org/D5095
https://phabricator.kde.org/D5096

:)

On 2017-03-18 05:49 PM, Jeremy Whiting wrote:

> Hi John,
>
> Those changes look good to me, but as Kevin said please split it into
> two commits since it fixes two issues.
>
> thanks,
> Jeremy
>
> On Sat, Mar 18, 2017 at 12:50 AM, John Salatas <[hidden email]>
> wrote:
>
>> Hi.
>>
>> Seems that lately kompare isn't so active. Is anyone watching this
>> list?
>>
>> I created a Differential Review (https://phabricator.kde.org/D5075
>> [1]), fixing some issues, but wasn't sure who should I add to review
>> it, so I just added the last two committers according to git's logs.
>> :)
>>
>> Can someone have a look?
>>
>> Thanks!
>
>
>
> Links:
> ------
> [1] https://phabricator.kde.org/D5075