Kproperty Feature Request

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

Kproperty Feature Request

Adam Pigg-2
Jaroslaw

While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?

Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)

Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.

Cheers

Adam
Reply | Threaded
Open this post in threaded view
|

Re: Kproperty Feature Request

Jaroslaw Staniek-3


On Sunday, 6 November 2016, Adam Pigg <[hidden email]> wrote:
> Jaroslaw
> While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?
> Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)
> Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.


Thanks Adam, is there a feature set's regression in KReport or just inconvenience?

--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
Reply | Threaded
Open this post in threaded view
|

Re: Kproperty Feature Request

Adam Pigg-2
Its only a regression in my d-ptr branch for 3.1 .... size/position will display in points at the moment, used to display in user-units.  It could be worked around but would be hacky, seems appropriate for kproperty to do the translation as it does with non-composed properties

It is display-only as it saves/loads in points, so the internal representation should stay in points

On Sun, 6 Nov 2016 at 16:58 Jaroslaw Staniek <[hidden email]> wrote:


On Sunday, 6 November 2016, Adam Pigg <[hidden email]> wrote:
> Jaroslaw
> While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?
> Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)
> Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.


Thanks Adam, is there a feature set's regression in KReport or just inconvenience?

--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
Reply | Threaded
Open this post in threaded view
|

Re: Kproperty Feature Request

Jaroslaw Staniek-3


On 6 November 2016 at 19:44, Adam Pigg <[hidden email]> wrote:
Its only a regression in my d-ptr branch for 3.1 .... size/position will display in points at the moment, used to display in user-units.  It could be worked around but would be hacky, seems appropriate for kproperty to do the translation as it does with non-composed properties

It is display-only as it saves/loads in points, so the internal representation should stay in points


​Good. So let's assume it would be fixed​
 
​in KProperty 3.1.​


On Sun, 6 Nov 2016 at 16:58 Jaroslaw Staniek <[hidden email]> wrote:


On Sunday, 6 November 2016, Adam Pigg <[hidden email]> wrote:
> Jaroslaw
> While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?
> Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)
> Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.


Thanks Adam, is there a feature set's regression in KReport or just inconvenience?

--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek



--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
Reply | Threaded
Open this post in threaded view
|

Re: Kproperty Feature Request

Adam Pigg-2
i almost have a patch :)

i was being stupid and building an old version earlier!!


On Sun, 6 Nov 2016 at 19:50 Jaroslaw Staniek <[hidden email]> wrote:
On 6 November 2016 at 19:44, Adam Pigg <[hidden email]> wrote:
Its only a regression in my d-ptr branch for 3.1 .... size/position will display in points at the moment, used to display in user-units.  It could be worked around but would be hacky, seems appropriate for kproperty to do the translation as it does with non-composed properties

It is display-only as it saves/loads in points, so the internal representation should stay in points


​Good. So let's assume it would be fixed​
 
​in KProperty 3.1.​


On Sun, 6 Nov 2016 at 16:58 Jaroslaw Staniek <[hidden email]> wrote:


On Sunday, 6 November 2016, Adam Pigg <[hidden email]> wrote:
> Jaroslaw
> While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?
> Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)
> Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.


Thanks Adam, is there a feature set's regression in KReport or just inconvenience?

--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek



--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek
Reply | Threaded
Open this post in threaded view
|

Re: Kproperty Feature Request

Jaroslaw Staniek-3


On 6 November 2016 at 21:03, Adam Pigg <[hidden email]> wrote:
i almost have a patch :)

i was being stupid and building an old version earlier!!

​Well, as soon as we depend on some major feature we can bump version of kproperty (still 3.1 alpha though) and bump dependency in kreport to that version.



On Sun, 6 Nov 2016 at 19:50 Jaroslaw Staniek <[hidden email]> wrote:
On 6 November 2016 at 19:44, Adam Pigg <[hidden email]> wrote:
Its only a regression in my d-ptr branch for 3.1 .... size/position will display in points at the moment, used to display in user-units.  It could be worked around but would be hacky, seems appropriate for kproperty to do the translation as it does with non-composed properties

It is display-only as it saves/loads in points, so the internal representation should stay in points


​Good. So let's assume it would be fixed​
 
​in KProperty 3.1.​


On Sun, 6 Nov 2016 at 16:58 Jaroslaw Staniek <[hidden email]> wrote:


On Sunday, 6 November 2016, Adam Pigg <[hidden email]> wrote:
> Jaroslaw
> While im out, could you figure out if/why composed properties such as SizeF/Pointf should honor options set on them?
> Afaict, I have removed all my manual code in kreport for units in size/position thinking kproperty would do it, but it doesnt :)
> Looking at the code, i dont think KComposedPropertyInterface allows options to be forwarded to the child properties, but I might be looking at it from the wrong angle.


Thanks Adam, is there a feature set's regression in KReport or just inconvenience?

--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek



--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek



--
regards, Jaroslaw Staniek

KDE:
: A world-wide network of software engineers, artists, writers, translators
: and facilitators committed to Free Software development - http://kde.org
Calligra Suite:
: A graphic art and office suite - http://calligra.org
Kexi:
: A visual database apps builder - http://calligra.org/kexi
Qt Certified Specialist:
: http://www.linkedin.com/in/jstaniek