Re: Review Request 130215: Add a new button "Record screen" that allows to select a Screen Recording tool

classic Classic list List threaded Threaded
3 messages Options
Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130215: Add a new button "Record screen" that allows to select a Screen Recording tool

Nate Graham-2
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130215/

Hi Gregor, It looks great to me on first glance, but can you migrate this patch over to phabricator? Reviewboard is going to close down soon.


- Nathaniel Graham


On October 16th, 2017, 4:45 p.m. UTC, Gregor Mi wrote:

Review request for KDE Graphics, Boudhayan Gupta and Nathaniel Graham.
By Gregor Mi.

Updated Oct. 16, 2017, 4:45 p.m.

Repository: spectacle

Description

  • Adds a new button "Record screen" that allows to select a Screen Recording tool, currently Peek and SimpleScreenRecorder.
  • Makes use of KMoreTools; so minimal code changes required.
  • Why? -> When the user presses "Print Screen" Spectacle opens. From there it is now easy to select a Screen recording tool.

Diffs

  • CMakeLists.txt (66d0d86494755740ae871e9b5ac184f4d870280d)
  • src/CMakeLists.txt (ed9bb48cfd47bf97720b79ee64b67afc87dc0e06)
  • src/Gui/KSMainWindow.h (fe5104c9f621651eeab5b8acac80a87f1db0111b)
  • src/Gui/KSMainWindow.cpp (5a4dd77564e98b961adcadcec18e5d5fad4d4bb4)

View Diff

File Attachments

  • Screenshot of the new menu button
  • Reply | Threaded
    Open this post in threaded view
    |

    Re: Review Request 130215: Add a new button "Record screen" that allows to select a Screen Recording tool

    gregor.mi.sw
    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130215/

    On Oktober 17th, 2017, 2:28 vorm. UTC, Nathaniel Graham wrote:

    Hi Gregor, It looks great to me on first glance, but can you migrate this patch over to phabricator? Reviewboard is going to close down soon.

    Moved to Phabricator: https://phabricator.kde.org/D10295


    - Gregor


    On Oktober 16th, 2017, 4:45 nachm. UTC, Gregor Mi wrote:

    Review request for KDE Graphics, Boudhayan Gupta and Nathaniel Graham.
    By Gregor Mi.

    Updated Okt. 16, 2017, 4:45 nachm.

    Repository: spectacle

    Description

    • Adds a new button "Record screen" that allows to select a Screen Recording tool, currently Peek and SimpleScreenRecorder.
    • Makes use of KMoreTools; so minimal code changes required.
    • Why? -> When the user presses "Print Screen" Spectacle opens. From there it is now easy to select a Screen recording tool.

    Diffs

    • CMakeLists.txt (66d0d86494755740ae871e9b5ac184f4d870280d)
    • src/CMakeLists.txt (ed9bb48cfd47bf97720b79ee64b67afc87dc0e06)
    • src/Gui/KSMainWindow.h (fe5104c9f621651eeab5b8acac80a87f1db0111b)
    • src/Gui/KSMainWindow.cpp (5a4dd77564e98b961adcadcec18e5d5fad4d4bb4)

    View Diff

    File Attachments

  • Screenshot of the new menu button
  • Reply | Threaded
    Open this post in threaded view
    |

    Re: Review Request 130215: Add a new button "Record screen" that allows to select a Screen Recording tool

    gregor.mi.sw
    In reply to this post by Nate Graham-2
    This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130215/

    This change has been discarded.


    Review request for KDE Graphics, Boudhayan Gupta and Nathaniel Graham.
    By Gregor Mi.

    Updated Feb. 4, 2018, 2:03 nachm.

    Repository: spectacle

    Description

    • Adds a new button "Record screen" that allows to select a Screen Recording tool, currently Peek and SimpleScreenRecorder.
    • Makes use of KMoreTools; so minimal code changes required.
    • Why? -> When the user presses "Print Screen" Spectacle opens. From there it is now easy to select a Screen recording tool.

    Diffs

    • CMakeLists.txt (66d0d86494755740ae871e9b5ac184f4d870280d)
    • src/CMakeLists.txt (ed9bb48cfd47bf97720b79ee64b67afc87dc0e06)
    • src/Gui/KSMainWindow.h (fe5104c9f621651eeab5b8acac80a87f1db0111b)
    • src/Gui/KSMainWindow.cpp (5a4dd77564e98b961adcadcec18e5d5fad4d4bb4)

    View Diff

    File Attachments

  • Screenshot of the new menu button