Review Request 130132: Fix no Elapsed nor Remaining time information issue

classic Classic list List threaded Threaded
8 messages Options
Reply | Threaded
Open this post in threaded view
|

Review Request 130132: Fix no Elapsed nor Remaining time information issue

Leslie Zhai-3
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.
Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Anthony Fieroni
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.


- Anthony Fieroni


On Май 16th, 2017, 6:20 преди обяд EEST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated Май 16, 2017, 6:20 преди обяд

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Leslie Zhai-3
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

On 五月 16th, 2017, 11:56 a.m. CST, Anthony Fieroni wrote:

See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.

Hi Anthony,

But how to covert the Remaining time (for example 233434 ms) to toString("HH-mm-ss") (for example 00:02:43) by QDateTime? please give me a hint, thanks!

Regards, Leslie Zhai


- Leslie


On 五月 16th, 2017, 11:20 a.m. CST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated 五月 16, 2017, 11:20 a.m.

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Anthony Fieroni
In reply to this post by Anthony Fieroni
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

On Май 16th, 2017, 6:56 преди обяд EEST, Anthony Fieroni wrote:

See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.

On Май 16th, 2017, 7:32 преди обяд EEST, Leslie Zhai wrote:

Hi Anthony,

But how to covert the Remaining time (for example 233434 ms) to toString("HH-mm-ss") (for example 00:02:43) by QDateTime? please give me a hint, thanks!

Regards, Leslie Zhai

QTime().addSecs(elapsed).toString(""hh:mm:ss") even QTime().addSecs(elapsed).toString() http://doc.qt.io/qt-5/qtime.html#toString-1 If format is Qt::TextDate, the string format is HH:mm:ss; e.g. 1 second before midnight would be "23:59:59".


- Anthony


On Май 16th, 2017, 6:20 преди обяд EEST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated Май 16, 2017, 6:20 преди обяд

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Leslie Zhai-3
In reply to this post by Anthony Fieroni
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

On 五月 16th, 2017, 11:56 a.m. CST, Anthony Fieroni wrote:

See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.

On 五月 16th, 2017, 12:32 p.m. CST, Leslie Zhai wrote:

Hi Anthony,

But how to covert the Remaining time (for example 233434 ms) to toString("HH-mm-ss") (for example 00:02:43) by QDateTime? please give me a hint, thanks!

Regards, Leslie Zhai

On 五月 16th, 2017, 4:09 p.m. CST, Anthony Fieroni wrote:

QTime().addSecs(elapsed).toString(""hh:mm:ss") even QTime().addSecs(elapsed).toString() http://doc.qt.io/qt-5/qtime.html#toString-1 If format is Qt::TextDate, the string format is HH:mm:ss; e.g. 1 second before midnight would be "23:59:59".

Hi Anthony,

Thanks for your reply!

But for Qt5.8.0 the output of QTime().addMSecs(elapsed).toString("hh:mm:ss") or QTime().addSecs(elapsed).toString("hh:mm:ss") is Empty! and QTime().addSecs(elapsed).isValid() is false.

perhaps for Qt4.7.0 it is ok https://git.reviewboard.kde.org/r/120459/ I use QTime wrongly? or should I report the bug to Qt UPSTREAM?

Regards, Leslie Zhai


- Leslie


On 五月 16th, 2017, 11:20 a.m. CST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated 五月 16, 2017, 11:20 a.m.

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Anthony Fieroni
In reply to this post by Anthony Fieroni
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

On Май 16th, 2017, 6:56 преди обяд EEST, Anthony Fieroni wrote:

See http://doc.qt.io/qt-5/qdatetime.html#toString toString will do it for you.

On Май 16th, 2017, 7:32 преди обяд EEST, Leslie Zhai wrote:

Hi Anthony,

But how to covert the Remaining time (for example 233434 ms) to toString("HH-mm-ss") (for example 00:02:43) by QDateTime? please give me a hint, thanks!

Regards, Leslie Zhai

On Май 16th, 2017, 11:09 преди обяд EEST, Anthony Fieroni wrote:

QTime().addSecs(elapsed).toString(""hh:mm:ss") even QTime().addSecs(elapsed).toString() http://doc.qt.io/qt-5/qtime.html#toString-1 If format is Qt::TextDate, the string format is HH:mm:ss; e.g. 1 second before midnight would be "23:59:59".

On Май 17th, 2017, 5:03 преди обяд EEST, Leslie Zhai wrote:

Hi Anthony,

Thanks for your reply!

But for Qt5.8.0 the output of QTime().addMSecs(elapsed).toString("hh:mm:ss") or QTime().addSecs(elapsed).toString("hh:mm:ss") is Empty! and QTime().addSecs(elapsed).isValid() is false.

perhaps for Qt4.7.0 it is ok https://git.reviewboard.kde.org/r/120459/ I use QTime wrongly? or should I report the bug to Qt UPSTREAM?

Regards, Leslie Zhai

Yeah, you are right. QTime::fromMSecsSinceStartOfDay(elapsed).toString() // Note this will wrap if elapsed > 24h, but it should not happen in k3b :)


- Anthony


On Май 16th, 2017, 6:20 преди обяд EEST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated Май 16, 2017, 6:20 преди обяд

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Leslie Zhai-3
In reply to this post by Leslie Zhai-3
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated 五月 17, 2017, 3:05 p.m.

Changes

Hi Anthony,

Thanks for your hint!

Regards, Leslie Zhai

Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs (updated)

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff

Reply | Threaded
Open this post in threaded view
|

Re: Review Request 130132: Fix no Elapsed nor Remaining time information issue

Leslie Zhai-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130132/

This change has been marked as submitted.


Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Kai Uwe Broulik.
By Leslie Zhai.

Updated May 18, 2017, 10:24 a.m.

Changes

Submitted with commit 026a29ea79312a5adabe7c2a6c04cac2330eac5d by Leslie Zhai to branch master.
Bugs: 379448
Repository: k3b

Description

Hi KDE developer,

Cristian reported such bug to me, and I fixed it, but I can not git push now, please review it, if LGTU, please git push on my behalf, thanks a lot!

Regards, Leslie Zhai

Diffs

  • src/k3bjobprogressdialog.cpp (1091f6c65)

View Diff