Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

Leslie Zhai-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130212/

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Harald Sitter.
By Leslie Zhai.
Bugs: 383011
Repository: k3b

Description

Hi KDE developers,

tempDir was defined as QScopedPointer<QTemporaryDir> https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R40 it is easy to create a unique directory for temporary use, and QScopedPointer's destructor will free the allocated memory automatically, brain-free :)

but it still mkdir all parenets directories in complicated way https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R113

so I just mkpath for temporary VIDEO_TS directory and provide correct temporary path, such as /tmp/k3bVideoDvdfINBwV to genisoimage, please review my patch, and give me some suggestion, thanks a lot!

Regards, Leslie Zhai

Diffs

  • libk3b/projects/videodvd/k3bvideodvdimager.cpp (a8ae69a)

View Diff

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

Harald Sitter-7
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130212/

Please use phabricator, reviewboard is deprecated and getting killed at some point https://community.kde.org/Infrastructure/Phabricator


- Harald Sitter


On August 2nd, 2017, 4:51 a.m. UTC, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Harald Sitter.
By Leslie Zhai.

Updated Aug. 2, 2017, 4:51 a.m.

Bugs: 383011
Repository: k3b

Description

Hi KDE developers,

tempDir was defined as QScopedPointer<QTemporaryDir> https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R40 it is easy to create a unique directory for temporary use, and QScopedPointer's destructor will free the allocated memory automatically, brain-free :)

but it still mkdir all parenets directories in complicated way https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R113

so I just mkpath for temporary VIDEO_TS directory and provide correct temporary path, such as /tmp/k3bVideoDvdfINBwV to genisoimage, please review my patch, and give me some suggestion, thanks a lot!

Regards, Leslie Zhai

Diffs

  • libk3b/projects/videodvd/k3bvideodvdimager.cpp (a8ae69a)

View Diff

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

Leslie Zhai-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130212/

On 八月 2nd, 2017, 4:11 p.m. CST, Harald Sitter wrote:

Please use phabricator, reviewboard is deprecated and getting killed at some point https://community.kde.org/Infrastructure/Phabricator

Thanks for your hint! https://phabricator.kde.org/D7063


- Leslie


On 八月 2nd, 2017, 12:51 p.m. CST, Leslie Zhai wrote:

Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Harald Sitter.
By Leslie Zhai.

Updated 八月 2, 2017, 12:51 p.m.

Bugs: 383011
Repository: k3b

Description

Hi KDE developers,

tempDir was defined as QScopedPointer<QTemporaryDir> https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R40 it is easy to create a unique directory for temporary use, and QScopedPointer's destructor will free the allocated memory automatically, brain-free :)

but it still mkdir all parenets directories in complicated way https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R113

so I just mkpath for temporary VIDEO_TS directory and provide correct temporary path, such as /tmp/k3bVideoDvdfINBwV to genisoimage, please review my patch, and give me some suggestion, thanks a lot!

Regards, Leslie Zhai

Diffs

  • libk3b/projects/videodvd/k3bvideodvdimager.cpp (a8ae69a)

View Diff

Reply | Threaded
Open this post in threaded view
|  
Report Content as Inappropriate

Re: Review Request 130212: Fix confused by the different with QTemporaryDir and QDir issue

Leslie Zhai-4
In reply to this post by Leslie Zhai-4
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/130212/

This change has been discarded.


Review request for KDE Multimedia, Albert Astals Cid, Anthony Fieroni, and Harald Sitter.
By Leslie Zhai.

Updated Aug. 2, 2017, 6:01 p.m.

Bugs: 383011
Repository: k3b

Description

Hi KDE developers,

tempDir was defined as QScopedPointer<QTemporaryDir> https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R40 it is easy to create a unique directory for temporary use, and QScopedPointer's destructor will free the allocated memory automatically, brain-free :)

but it still mkdir all parenets directories in complicated way https://github.com/KDE/k3b/commit/05cd636c9dfb35fdeea666b581c1f2b9c3820a90#diff-920d85bf84619674590c2e13a0428d00R113

so I just mkpath for temporary VIDEO_TS directory and provide correct temporary path, such as /tmp/k3bVideoDvdfINBwV to genisoimage, please review my patch, and give me some suggestion, thanks a lot!

Regards, Leslie Zhai

Diffs

  • libk3b/projects/videodvd/k3bvideodvdimager.cpp (a8ae69a)

View Diff

Loading...