[kompare] [Bug 347760] New: Kompare won't save the file after diff applied

classic Classic list List threaded Threaded
6 messages Options
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] New: Kompare won't save the file after diff applied

Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

            Bug ID: 347760
           Summary: Kompare won't save the file after diff applied
           Product: kompare
           Version: 4.1.3
          Platform: Kubuntu Packages
                OS: Linux
            Status: UNCONFIRMED
          Severity: grave
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

I open kompare on 2 directories to operate on their files, and after applying
them, the files won't save with their changes, and this is printed in the
konsole output:

libkomparediff: KompareModelList::saveDestination:
libkomparediff: Tempfilename (save) :  "/tmp/kompare.L12039"
libkomparediff: Model->path+file    :  "/home/franco/less/" "variables.less"
libkomparediff: info->localdest     :  "/home/franco/less/"
libkomparediff: DestinationURL      :   QUrl( "file:///home/franco/less/" )
libkomparediff: tmp                 :  "variables.less"
libkomparediff: fullDestinationPath :   QUrl(
"file:///home/franco/less/variables.less" )
Invalid URL:  QUrl( "/home/franco/less/variables.less" )
Invalid URL:  QUrl( "/home/franco/less/variables.less" )
Calling notify on "Sound"
Calling notify on "Taskbar"`

The command I use to start kompare is:

$ kompare /home/franco/less_old /home/franco/less

Reproducible: Always

Steps to Reproduce:
1. kompare directory_a directory_b
2. apply difference from file in directory_a to file in directory_b
3. try "Save" or "Save all"

Actual Results:  
Got "Could not create destination directory"

Expected Results:  
Modifications to files to be saved

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] Kompare won't save the file after diff applied

Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

--- Comment #1 from Franco Pellegrini <[hidden email]> ---
I had to downgrade, remove and install components to have this functionality
working back as it should:

kompare (4:14.12.3-0ubuntu1) -> (4:15.04.0-0ubuntu1~ubuntu15.04~ppa2)

Installed
libkomparediff2-4 (4:14.12.3-0ubuntu1)

Removed
kpart5-kompare (4:15.04.0-0ubuntu1~ubuntu15.04~ppa2)
libkompareinterface5:amd64 (4:15.04.0-0ubuntu1~ubuntu15.04~ppa2)
libkomparediff2-5:amd64 (4:15.04.0-0ubuntu1~ubuntu15.04~ppa1)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] Kompare won't save the file after diff applied

Franco Pellegrini
In reply to this post by Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

--- Comment #2 from Franco Pellegrini <[hidden email]> ---
Sorry, meant to say

kompare (4:15.04.0-0ubuntu1~ubuntu15.04~ppa2) ->  (4:14.12.3-0ubuntu1)

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] Kompare won't save the file after diff applied

Jeremy Whiting
In reply to this post by Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

Jeremy Whiting <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |CONFIRMED
                 CC|                            |[hidden email]
     Ever confirmed|0                           |1

--- Comment #3 from Jeremy Whiting <[hidden email]> ---
I've posted a patch to reviewboard for this at
https://git.reviewboard.kde.org/r/124163/

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] Kompare won't save the file after diff applied

Anke Boersma
In reply to this post by Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

[hidden email] changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 347760] Kompare won't save the file after diff applied

Jeremy Whiting
In reply to this post by Franco Pellegrini
https://bugs.kde.org/show_bug.cgi?id=347760

Jeremy Whiting <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
      Latest Commit|                            |http://commits.kde.org/libk
                   |                            |omparediff2/3cffb9abc3d0c0f
                   |                            |d3c861f65cc7738fbe7568b54
             Status|CONFIRMED                   |RESOLVED
         Resolution|---                         |FIXED

--- Comment #4 from Jeremy Whiting <[hidden email]> ---
Git commit 3cffb9abc3d0c0fd3c861f65cc7738fbe7568b54 by Jeremy Whiting.
Committed on 10/07/2015 at 16:59.
Pushed by whiting into branch 'master'.

Use KIO::Overwrite when saving a changed file otherwise it always fails.
REVIEW:124163

M  +2    -2    komparemodellist.cpp

http://commits.kde.org/libkomparediff2/3cffb9abc3d0c0fd3c861f65cc7738fbe7568b54

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel