[kompare] [Bug 365774] New: Editing a patch file does not work properly

classic Classic list List threaded Threaded
4 messages Options
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 365774] New: Editing a patch file does not work properly

James Baxter
https://bugs.kde.org/show_bug.cgi?id=365774

            Bug ID: 365774
           Summary: Editing a patch file does not work properly
           Product: kompare
           Version: 4.1.3
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]

I've started kompare: kompare mypatch.patch
The file contains diff output. First of all "The diff is malformed. Some lines
could not be parsed and will not be displayed in the diff view." appears
although I've created the file automatically. Then the file is loaded anyways
and shows the correct changes.
Now I want to undo changes by applying changes from the old file to the new
file to edit my patch file. Basically I want to remove some changes from the
patch file. This works until I want to save the patch file. Maybe the program
tries to save the target file instead. The "Save Diff" button is disabled as
well as the "Refresh Diff" button!

Btw. when starting kompare not via command line I have NO IDEA how to open a
patch file only.

Reproducible: Always

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 365774] Editing a patch file does not work properly

James Baxter
https://bugs.kde.org/show_bug.cgi?id=365774

--- Comment #1 from Barade <[hidden email]> ---
For the parsing error. I guess that the only lines which could cause problems
are the diff annotations?

They have the following form in my patch file:
diff -Nur -x '*.o' -x '*.so' -x '*.la' -x '*.oo' -x '*.a' -x doc -x scripts -x
build -x '*.dd' -x '*.d' -x define_annotation.h
../../projektarbeit2oldversion/viewerandstudio/lib/opengl/framework/data/ambassador.cpp
../lib/opengl/framework/data/ambassador.cpp
---
../../projektarbeit2oldversion/viewerandstudio/lib/opengl/framework/data/ambassador.cpp
    2016-05-30 16:45:08.912805998 +0200
+++ ../lib/opengl/framework/data/ambassador.cpp 2016-06-27 00:13:25.101018880
+0200
@@ -14,6 +14,7 @@


Then the changes follow with + or -

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 365774] Editing a patch file does not work properly

James Baxter
In reply to this post by James Baxter
https://bugs.kde.org/show_bug.cgi?id=365774

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|---                         |INVALID

--- Comment #2 from Kevin Kofler <[hidden email]> ---
Kompare does not edit patch files. The save buttons are indeed for saving the
target file(s) (you can actually modify both the "source" and the "target"
file, thus the "(s)").

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 365774] Editing a patch file does not work properly

James Baxter
In reply to this post by James Baxter
https://bugs.kde.org/show_bug.cgi?id=365774

--- Comment #3 from Barade <[hidden email]> ---
Can I change this to a feature request then? It would be useful to have a tool
for modifying patch files.

--
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Kompare-devel mailing list
[hidden email]
https://mail.kde.org/mailman/listinfo/kompare-devel