[kompare] [Bug 390024] New: "Compare" button not enabled on the initial dialog even after filling the file names

classic Classic list List threaded Threaded
16 messages Options
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] New: "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

            Bug ID: 390024
           Summary: "Compare" button not enabled on the initial dialog
                    even after filling the file names
           Product: kompare
           Version: 4.1.3
          Platform: Other
                OS: Linux
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: [hidden email]
          Reporter: [hidden email]
  Target Milestone: ---

When kompare is invoked without files as argument, the initial dialog is
opened.
When the Source and the Destination field are filled, either files or
directories, the "Compare" button is still disabled.

Kompare 4.1.3 from KDE Applications 17.12.1.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Jeremy Whiting <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #1 from Jeremy Whiting <[hidden email]> ---
Luigi, it seems to work fine here. From looking at the code a KUrlRequester is
used for each line edit and if either of them change they tell the ui to check
if they are both not empty and enable that button. I tried here with the
packaged version in debian buster and it worked ok, can you recreate this every
time there?

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #2 from Luigi Toscano <[hidden email]> ---
Right: you don't have to type. If you type the file path, it works. If you
click on the right buttons and browse and select the name from there, then the
signal is not triggered.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #3 from Jeremy Whiting <[hidden email]> ---
I used the buttons to select files here which worked. That's not working there?
I wonder if KURLRequester has a regression possibly. We are connecting to it's
textChanged signal which seems to be working here with the kf5 packages I have
from debian.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
     Ever confirmed|0                           |1
           Platform|Other                       |Fedora RPMs
             Status|UNCONFIRMED                 |CONFIRMED

--- Comment #4 from Kevin Kofler <[hidden email]> ---
I can reproduce the issue here:
kompare 4.1.3 from kompare-17.12.1-1.fc27.x86_64
kf5 5.42.0 from Fedora RPMs
qt5-qtbase 5.9.2 from Fedora RPMs
which is why I asked Luigi to file this issue here to begin with.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #5 from Jeremy Whiting <[hidden email]> ---
Yep, I can recreate with latest kompare and kf5 from git. Let's see if I can
find the cause now :)

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #6 from Jeremy Whiting <[hidden email]> ---
https://cgit.kde.org/kio.git/commit/?id=ffffa43aea3ebc697fad4be8be821b94c8374d08
is definitely the cause undoing the bits of that commit in kurlrequester.cpp
fix the bug, but I'm not sure why yet. We are connecting to KURLRequester's
textChanged signal in kompare, but we are changing the KURLRequester's
KUrlComboBox itself with setUrl when those buttons are clicked.
KUrlComboBox::setUrl turns off its own signals, so I don't see how that ever
worked except that we were connected to the lineedit rather than the QComboBox
I guess.

A simple fix is in KUrlComboBox setUrl to emit textChanged after changing the
url in setUrl, but I'm not sure if that makes the most sense or not.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

--- Comment #7 from Jeremy Whiting <[hidden email]> ---
Alternatively we could have the FilesPage emit a signal after it calls setUrl
on the KUrlCombobox

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #8 from Kevin Kofler <[hidden email]> ---
*** Bug 391405 has been marked as a duplicate of this bug. ***

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #9 from Kevin Kofler <[hidden email]> ---
Just so the workaround is also clearly visible here, I am reposting
https://bugs.kde.org/show_bug.cgi?id=391405#c2 here:

Jeremy Whiting wrote:
> As a temporary workaround after choosing files typing anything in either box
> (even a space) activates the button. Working on the proper solution for the
> bug in frameworks though.

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Kevin Kofler <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|[hidden email]      |

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Simon Andric <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Francesco Turco <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Karsten de Freese <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Rik Mills <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--- Comment #10 from Rik Mills <[hidden email]> ---
This bug is still present with Kompare 18.08 and latest frameworks master

--
You are receiving this mail because:
You are the assignee for the bug.
Reply | Threaded
Open this post in threaded view
|

[kompare] [Bug 390024] "Compare" button not enabled on the initial dialog even after filling the file names

Peter Simonsson-2
In reply to this post by Peter Simonsson-2
https://bugs.kde.org/show_bug.cgi?id=390024

Marco Parillo <[hidden email]> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |[hidden email]

--
You are receiving this mail because:
You are the assignee for the bug.